Extend getNonStdFontMap for non-embedded versions of the ItcSymbol font (issue 11532)
#13952
Conversation
|
I didn't really have time to create a reduced test-case right now, but figured that submitting the patch with a linked test-case was better than the issue remaining open even longer; sorry about that! /botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a568b368ec96f3f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a568b368ec96f3f/output.txt Total script time: 9.71 mins Published |
Snuffleupagus
changed the title
getNonStdFontMap for non-embedded version of the ItcSymbol font (issue 11532)getNonStdFontMap for non-embedded versions of the ItcSymbol font (issue 11532)
…font (issue 11532) Despite its name, the fonts in ItcSymbol-family are "regular" fonts and not Symbol ones. However, given that the font name contains the word "Symbol" we ended up picking the wrong code-path in the `Font.fallbackToSystemFont`-method. *Please note:* While this patch ensures that the text becomes readable, by falling back a standard font, the rendering will obviously not be perfect. However, that's the PDF generators "fault" since non-embedded fonts cannot be guaranteed to render correctly in all environments.
Snuffleupagus
force-pushed
the
ItcSymbol
branch
from
09a6789 to
ba9f004
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1a416e8ca56c68b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ec7c74e477accd8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ec7c74e477accd8/output.txt Total script time: 28.13 mins
Image differences available at: http://54.67.70.0:8877/ec7c74e477accd8/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b7180be0d46ea16/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1a416e8ca56c68b/output.txt Total script time: 40.02 mins
Image differences available at: http://3.101.106.178:8877/1a416e8ca56c68b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b7180be0d46ea16/output.txt Total script time: 30.38 mins
Image differences available at: http://54.67.70.0:8877/b7180be0d46ea16/reftest-analyzer.html#web=eq.log |
|
Not sure what's up with the Linux bot... /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/0c09162203ffcdc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0c09162203ffcdc/output.txt Total script time: 9.79 mins Published |
|
Looks good! I did find the old rendering amusing though ;-) |
Despite its name, the fonts in ItcSymbol-family are "regular" fonts and not Symbol ones. However, given that the font name contains the word "Symbol" we ended up picking the wrong code-path in the
Font.fallbackToSystemFont-method.Please note: While this patch ensures that the text becomes readable, by falling back a standard font, the rendering will obviously not be perfect. However, that's the PDF generators "fault" since non-embedded fonts cannot be guaranteed to render correctly in all environments.
Fixes #11532